From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 6 Nov 2012 22:15:39 +0000 (-0500)
Subject: Fix a stupid logic-error in warnings about low ports.
X-Git-Tag: tor-0.2.4.6-alpha~11^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=11c467f6431773abaa4cced036b3bf87d4ea7f22;p=thirdparty%2Ftor.git

Fix a stupid logic-error in warnings about low ports.

Instead of warning about low ports that are advertised, we should have
been warning about low ports that we're listening on.  Bug 7285, fix
on 0.2.3.9-alpha.
---

diff --git a/changes/bug7285 b/changes/bug7285
new file mode 100644
index 0000000000..3c00205a4c
--- /dev/null
+++ b/changes/bug7285
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Warn when we are binding low ports when hibernation is enabled;
+      previously we had warned when we were _advertising_ low ports with
+      hibernation enabled. Fixes bug 7285; bugfix on 0.2.3.9-alpha.
diff --git a/src/or/config.c b/src/or/config.c
index dca49f5cf4..bf32fae0e2 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -5004,7 +5004,7 @@ check_server_ports(const smartlist_t *ports,
       continue;
     }
 #ifndef _WIN32
-    if (!port->no_advertise && port->port < 1024)
+    if (!port->no_listen && port->port < 1024)
       ++n_low_port;
 #endif
   } SMARTLIST_FOREACH_END(port);