From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 22 Aug 2012 17:40:36 +0000 (+0100)
Subject: Quiet the compiler
X-Git-Tag: release_3_0_0_beta0~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=11e03cd05f6bd200ec70e36b9f7a78da5d6eb4a3;p=thirdparty%2Ffreeradius-server.git

Quiet the compiler
---

diff --git a/src/modules/rlm_sql/sql.c b/src/modules/rlm_sql/sql.c
index f4a7aed8de6..ce576c867d4 100644
--- a/src/modules/rlm_sql/sql.c
+++ b/src/modules/rlm_sql/sql.c
@@ -429,13 +429,15 @@ void rlm_sql_query_log(SQL_INST *inst, REQUEST *request,
 
 	fd = open(filename, O_WRONLY | O_APPEND | O_CREAT, 0666);
 	if (fd < 0) {
-		radlog(L_ERR, "rlm_sql (%s): Couldn't open file %s: %s",
+		radlog(L_ERR, "rlm_sql (%s): Couldn't open logfile %s: %s",
 		       inst->config->xlat_name, buffer, strerror(errno));
 		return;
 	}
 
 	rad_lockfd(fd, MAX_QUERY_LEN);
-	write(fd, query, strlen(query));
-	write(fd, ";\n", 2);
+	if ((write(fd, query, strlen(query) < 0) || (write(fd, ";\n", 2) < 0)))
+		radlog(L_ERR, "rlm_sql (%s): Failed writing to logfile %s: %s",
+		       inst->config->xlat_name, buffer, strerror(errno));
+
 	close(fd);		/* and release the lock */
 }