From: lpsolit%gmail.com <>
Date: Thu, 8 Jan 2009 00:06:49 +0000 (+0000)
Subject: Bug 472549: Ignore undefined values when committing user pref changes - Patch by... 
X-Git-Tag: bugzilla-3.3.2~56
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=11fa9ce3596363a4d4badd7960ae73e8dc535050;p=thirdparty%2Fbugzilla.git

Bug 472549: Ignore undefined values when committing user pref changes - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
---

diff --git a/userprefs.cgi b/userprefs.cgi
index 1bf2d7f5f3..085372bac5 100755
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -127,7 +127,6 @@ sub SaveAccount {
             $cgi->param('Bugzilla_password') 
               || ThrowUserError("old_password_required");
 
-            use Bugzilla::Token;
             # Block multiple email changes for the same user.
             if (Bugzilla::Token::HasEmailChangeToken($user->id)) {
                 ThrowUserError("email_change_in_progress");
@@ -183,6 +182,7 @@ sub SaveSettings {
     foreach my $name (@setting_list) {
         next if ! ($settings->{$name}->{'is_enabled'});
         my $value = $cgi->param($name);
+        next unless defined $value;
         my $setting = new Bugzilla::User::Setting($name);
 
         if ($value eq "${name}-isdefault" ) {