From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 2 Nov 2017 15:50:05 +0000 (-0400)
Subject: do run-time check of rbtree_insert()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=12224672ce3d0a78b1cd03083bf096f2a1795752;p=thirdparty%2Ffreeradius-server.git

do run-time check of rbtree_insert()
---

diff --git a/src/main/xlat_func.c b/src/main/xlat_func.c
index 9c7f06a619f..2f6aa035fdb 100644
--- a/src/main/xlat_func.c
+++ b/src/main/xlat_func.c
@@ -625,7 +625,6 @@ int xlat_register(void *mod_inst, char const *name,
 {
 	xlat_t	*c;
 	xlat_t	my_xlat;
-	rbnode_t *node;
 
 	if (!name || !*name) {
 		ERROR("%s: Invalid xlat name", __FUNCTION__);
@@ -725,7 +724,12 @@ int xlat_register(void *mod_inst, char const *name,
 
 	DEBUG3("%s: %s", c->name, __FUNCTION__);
 
-	MEM(node = rbtree_insert_node(xlat_root, c));
+	if (!rbtree_insert(xlat_root, c)) {
+		ERROR("Failed inserting xlat registration for %s",
+		      c->name);
+		talloc_free(c);
+		return -1;
+	}
 
 	return 0;
 }