From: Ján Tomko <jtomko@redhat.com>
Date: Wed, 23 Aug 2017 14:32:28 +0000 (+0200)
Subject: conf: check address type for USB hostdevs
X-Git-Tag: v3.7.0-rc1~50
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=126e6f381a5429b27aac008c4873f101116da95d;p=thirdparty%2Flibvirt.git

conf: check address type for USB hostdevs

https://bugzilla.redhat.com/show_bug.cgi?id=1225339
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 33470ffcb0..478feb92d8 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5287,6 +5287,13 @@ virDomainHostdevDefValidate(const virDomainHostdevDef *hostdev)
             }
             break;
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
+            if (hostdev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
+                hostdev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB) {
+                virReportError(VIR_ERR_XML_ERROR, "%s",
+                               _("USB host device must use 'usb' address type"));
+                return -1;
+            }
+            break;
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV:
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST:
             break;