From: Victor Julien <vjulien@oisf.net>
Date: Wed, 27 Apr 2022 14:37:28 +0000 (+0200)
Subject: stream/reassembly: reduce scope of variable
X-Git-Tag: suricata-7.0.0-beta1~619
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1282b179cc4373fa30313f4f79aa9a8a7a56726e;p=thirdparty%2Fsuricata.git

stream/reassembly: reduce scope of variable
---

diff --git a/src/stream-tcp-reassemble.c b/src/stream-tcp-reassemble.c
index 5956e1e5d5..37d5670047 100644
--- a/src/stream-tcp-reassemble.c
+++ b/src/stream-tcp-reassemble.c
@@ -1110,14 +1110,13 @@ static int ReassembleUpdateAppLayer (ThreadVars *tv,
 
     const uint8_t *mydata;
     uint32_t mydata_len;
-    bool gap_ahead = false;
     bool last_was_gap = false;
 
     while (1) {
         const uint8_t flags = StreamGetAppLayerFlags(ssn, *stream, p);
         bool check_for_gap_ahead = ((*stream)->data_required > 0);
-        gap_ahead = GetAppBuffer(*stream, &mydata, &mydata_len,
-                app_progress, check_for_gap_ahead);
+        bool gap_ahead =
+                GetAppBuffer(*stream, &mydata, &mydata_len, app_progress, check_for_gap_ahead);
         if (last_was_gap && mydata_len == 0) {
             break;
         }