From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 25 Oct 2019 02:29:28 +0000 (-0400)
Subject: Disallow memory tests from running on Windows
X-Git-Tag: rel_1_4_0b1~654^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=12ad9204a241c2c48477f717d184b1c8dec8270b;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Disallow memory tests from running on Windows

These tests fail with multiprocess errors involving pickling
of the profile file.  The memory tests are not critical
for windows development nor are the profiling tests overall
as they are against platform independent measurements.

Fixes: #4946
Change-Id: Iaeb3958e59ce7709ba6af3cf9d7baf2a4922bb9b
---

diff --git a/lib/sqlalchemy/testing/requirements.py b/lib/sqlalchemy/testing/requirements.py
index 62e442b6b4..c45156d6b4 100644
--- a/lib/sqlalchemy/testing/requirements.py
+++ b/lib/sqlalchemy/testing/requirements.py
@@ -15,6 +15,7 @@ to provide specific inclusion/exclusions.
 
 """
 
+import platform
 import sys
 
 from . import exclusions
@@ -951,6 +952,16 @@ class SuiteRequirements(Requirements):
             lambda config: config.options.low_connections
         )
 
+    @property
+    def no_windows(self):
+        return exclusions.skip_if(self._running_on_windows())
+
+    def _running_on_windows(self):
+        return exclusions.LambdaPredicate(
+            lambda: platform.system() == "Windows",
+            description="running on Windows",
+        )
+
     @property
     def timing_intensive(self):
         return exclusions.requires_tag("timing_intensive")
diff --git a/test/aaa_profiling/test_memusage.py b/test/aaa_profiling/test_memusage.py
index 431e53b1ba..efeeff9e00 100644
--- a/test/aaa_profiling/test_memusage.py
+++ b/test/aaa_profiling/test_memusage.py
@@ -188,7 +188,7 @@ class EnsureZeroed(fixtures.ORMTest):
 
 class MemUsageTest(EnsureZeroed):
     __tags__ = ("memory_intensive",)
-    __requires__ = ("cpython",)
+    __requires__ = ("cpython", "no_windows")
 
     def test_type_compile(self):
         from sqlalchemy.dialects.sqlite.base import dialect as SQLiteDialect
diff --git a/test/requirements.py b/test/requirements.py
index a0d984ef4b..739f90b955 100644
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -312,6 +312,7 @@ class DefaultRequirements(SuiteRequirements):
             [
                 no_support("oracle", "Oracle XE usually can't handle these"),
                 no_support("mssql+pyodbc", "MS ODBC drivers struggle"),
+                self._running_on_windows(),
             ]
         )