From: Richard Guenther Date: Thu, 31 Jul 2008 14:12:24 +0000 (+0000) Subject: re PR tree-optimization/36978 (ICE in gimple_cond_set_lhs for -O2 -funswitch-loops... X-Git-Tag: releases/gcc-4.4.0~3553 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=12aea97a8d4abf8c33654cc5de3c71debf3ce764;p=thirdparty%2Fgcc.git re PR tree-optimization/36978 (ICE in gimple_cond_set_lhs for -O2 -funswitch-loops after tuples merge) 2008-07-31 Richard Guenther PR tree-optimization/36978 * tree-ssa-loop-unswitch.c (tree_may_unswitch_on): Do not fold the generated condition. * gcc.dg/torture/pr36978.c: New testcase. From-SVN: r138415 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index cb7a67b65139..c83a2faa81cd 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2008-07-31 Richard Guenther + + PR tree-optimization/36978 + * tree-ssa-loop-unswitch.c (tree_may_unswitch_on): Do not fold + the generated condition. + 2008-07-31 Richard Guenther * passes.c (init_optimization_passes): Always call diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ccbd9711809a..f6e855abd083 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2008-07-31 Richard Guenther + + PR tree-optimization/36978 + * gcc.dg/torture/pr36978.c: New testcase. + 2008-07-31 Arnaud Charlet * gnat.dg/sync_iface_test.ad[s,b]: New test. diff --git a/gcc/testsuite/gcc.dg/torture/pr36978.c b/gcc/testsuite/gcc.dg/torture/pr36978.c new file mode 100644 index 000000000000..cd1af4ebc081 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr36978.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-funswitch-loops" } */ + +unsigned short status; +void foo (const _Bool flag) +{ + if (status == 2 || status == 7) + { + while (status != 2 && (status != 7 || !flag)) + { + } + } +} + diff --git a/gcc/tree-ssa-loop-unswitch.c b/gcc/tree-ssa-loop-unswitch.c index 8ece4aca4ab3..850270f49c03 100644 --- a/gcc/tree-ssa-loop-unswitch.c +++ b/gcc/tree-ssa-loop-unswitch.c @@ -123,8 +123,8 @@ tree_may_unswitch_on (basic_block bb, struct loop *loop) return NULL_TREE; } - cond = fold_build2 (gimple_cond_code (stmt), boolean_type_node, - gimple_cond_lhs (stmt), gimple_cond_rhs (stmt)); + cond = build2 (gimple_cond_code (stmt), boolean_type_node, + gimple_cond_lhs (stmt), gimple_cond_rhs (stmt)); /* To keep the things simple, we do not directly remove the conditions, but just replace tests with 0/1. Prevent the infinite loop where we