From: XhmikosR Date: Wed, 10 Jun 2020 15:42:21 +0000 (+0300) Subject: collapse.js: return early. X-Git-Tag: v5.0.0-alpha2~259 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=12b754800c5bc56bd0b757e335d70cee439400b7;p=thirdparty%2Fbootstrap.git collapse.js: return early. --- diff --git a/js/src/collapse.js b/js/src/collapse.js index be65529556..693e7ee2c8 100644 --- a/js/src/collapse.js +++ b/js/src/collapse.js @@ -318,21 +318,21 @@ class Collapse { } _addAriaAndCollapsedClass(element, triggerArray) { - if (element) { - const isOpen = element.classList.contains(CLASS_NAME_SHOW) - - if (triggerArray.length) { - triggerArray.forEach(elem => { - if (isOpen) { - elem.classList.remove(CLASS_NAME_COLLAPSED) - } else { - elem.classList.add(CLASS_NAME_COLLAPSED) - } + if (!element || !triggerArray.length) { + return + } - elem.setAttribute('aria-expanded', isOpen) - }) + const isOpen = element.classList.contains(CLASS_NAME_SHOW) + + triggerArray.forEach(elem => { + if (isOpen) { + elem.classList.remove(CLASS_NAME_COLLAPSED) + } else { + elem.classList.add(CLASS_NAME_COLLAPSED) } - } + + elem.setAttribute('aria-expanded', isOpen) + }) } // Static