From: Andreas Schneider <asn@samba.org>
Date: Tue, 15 Mar 2022 12:02:05 +0000 (+0100)
Subject: s3:libads: Check print_canonical_sockaddr_with_port() for NULL in get_kdc_ip_string()
X-Git-Tag: tevent-0.12.0~443
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=12c843ad0a97fcbaaea738b82941533e5d2aec99;p=thirdparty%2Fsamba.git

s3:libads: Check print_canonical_sockaddr_with_port() for NULL in get_kdc_ip_string()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15016

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
---

diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 2087dc1e6f9..20dceeefb22 100644
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -435,13 +435,18 @@ static char *get_kdc_ip_string(char *mem_ctx,
 	NTSTATUS status;
 	bool ok;
 	char *kdc_str = NULL;
+	char *canon_sockaddr = NULL;
 
 	SMB_ASSERT(pss != NULL);
 
+	canon_sockaddr = print_canonical_sockaddr_with_port(frame, pss);
+	if (canon_sockaddr == NULL) {
+		goto out;
+	}
+
 	kdc_str = talloc_asprintf(frame,
 				  "\t\tkdc = %s\n",
-				  print_canonical_sockaddr_with_port(mem_ctx,
-								     pss));
+				  canon_sockaddr);
 	if (kdc_str == NULL) {
 		goto out;
 	}