From: Bart Van Assche <bvanassche@acm.org>
Date: Thu, 4 Jun 2009 09:11:28 +0000 (+0000)
Subject: tsan_unittest.cpp does now compile cleanly even with -Wshadown enabled.
X-Git-Tag: svn/VALGRIND_3_5_0~539
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=130b0328d54ebb4bfdf3dc2b0e5d5e744772affb;p=thirdparty%2Fvalgrind.git

tsan_unittest.cpp does now compile cleanly even with -Wshadown enabled.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10241
---

diff --git a/drd/tests/Makefile.am b/drd/tests/Makefile.am
index ceaec5413b..d4ffdadffc 100644
--- a/drd/tests/Makefile.am
+++ b/drd/tests/Makefile.am
@@ -293,8 +293,7 @@ new_delete_SOURCES          = new_delete.cpp
 
 tsan_unittest_SOURCES       = tsan_unittest.cpp
 tsan_unittest_CXXFLAGS      = $(AM_CXXFLAGS) \
-			-DTHREAD_WRAPPERS='"tsan_thread_wrappers_pthread.h"' \
-			-Wno-sign-compare -Wno-shadow
+			-DTHREAD_WRAPPERS='"tsan_thread_wrappers_pthread.h"'
 
 if HAVE_BOOST_1_35
 boost_thread_SOURCES        = boost_thread.cpp
diff --git a/drd/tests/tsan_unittest.cpp b/drd/tests/tsan_unittest.cpp
index c3d4ec4791..dd42cd8e58 100644
--- a/drd/tests/tsan_unittest.cpp
+++ b/drd/tests/tsan_unittest.cpp
@@ -1691,7 +1691,7 @@ void Run() {
 
   std::vector<MyThread*> vec(Nlog);
 
-  for (int i = 0; i < N_iter; i++) {
+  for (int j = 0; j < N_iter; j++) {
     // Create and start Nlog threads
     for (int i = 0; i < Nlog; i++) {
       vec[i] = new MyThread(Worker);
@@ -5413,11 +5413,11 @@ void Run() {
 
   // do few more random publishes.
   for (int i = 0; i < 20; i++) {
-    int beg = rand() % N;
-    int size = (rand() % (N - beg)) + 1;
+    const int begin = rand() % N;
+    const int size = (rand() % (N - begin)) + 1;
     CHECK(size > 0);
-    CHECK(beg + size <= N);
-    PublishRange(beg, beg + size);
+    CHECK(begin + size <= N);
+    PublishRange(begin, begin + size);
   }
 
   printf("GLOB = %d\n", (int)GLOB[0]);