From: Ana María Martínez Gómez <ammartinez@suse.de>
Date: Tue, 5 Jun 2018 23:45:21 +0000 (+0200)
Subject: Document how to try the changes (#1920)
X-Git-Tag: 0.7.2~106
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=13199b8f51ee4cfb431e783fd83ddb2645215052;p=thirdparty%2Fbulma.git

Document how to try the changes (#1920)

* Document how to try the changes

Add to the contributing guide how to rebuild the css and where the
documentation to try the documentation changes is.

* Remove Bulma dependencies installation form PR template

Install Bulma dependencies is not needed to send a PR.

* Add how to try your changes to PR templates

And after that ask if you tried the changes.
---

diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index f37b30c34..f154d95a2 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -13,6 +13,17 @@ Thanks for helping out! 😇
 * Limit the first line to 72 characters or fewer
 * Reference issues and pull requests liberally
 
+### Try your changes
+
+When modifying any `.sass`, you will need to rebuild the css. You can do this by running:
+
+```
+npm install
+npm run build
+```
+
+To see documentation changes check [the documentation readme](docs/README.md).
+
 ### Bulma Sass styleguide
 
 * **No semi-colons** `;` or **curly braces** `{` `}`
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 91c9a15bd..4a92110f6 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -16,13 +16,14 @@ This is a **new feature | improvement | bugfix | documentation fix**.
 <!-- Think of performance, build time, usability, complexity, coupling…) -->
 
 ### Testing Done
-<!-- How have you confirmed this feature works? -->
-<!-- Please explain more than "Yes". -->
 
 <!-- BEFORE SUBMITTING YOUR PR, MAKE SURE TO FOLLOW THESE STEPS: -->
 <!-- 1. Pull the latest `master` branch -->
-<!-- 2. Run `npm install` to install all Bulma dependencies -->
-<!-- 3. Make sure your Sass code is compliant with the [Bulma Sass styleguide](https://github.com/jgthms/bulma/blob/master/.github/CONTRIBUTING.md#bulma-sass-styleguide) -->
-<!-- 4. Make sure your PR only affects `.sass` or documentation files -->
+<!-- 2. Make sure your Sass code is compliant with the [Bulma Sass styleguide](https://github.com/jgthms/bulma/blob/master/.github/CONTRIBUTING.md#bulma-sass-styleguide) -->
+<!-- 3. Make sure your PR only affects `.sass` or documentation files -->
+<!-- 4. [Try your changes](https://github.com/jgthms/bulma/blob/master/.github/CONTRIBUTING.md#try-your-changes). -->
+
+<!-- How have you confirmed this feature works? -->
+<!-- Please explain more than "Yes". -->
 
 <!-- Thanks! -->