From: Stefan Metzmacher <metze@samba.org>
Date: Mon, 28 Oct 2024 15:54:48 +0000 (+0100)
Subject: libcli/auth: return INVALID_PARAMETER for DES in netlogon_creds_{de,en}crypt_samlogon... 
X-Git-Tag: tdb-1.4.13~774
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=131f5c0b251e456c466eaca744525504e1d69492;p=thirdparty%2Fsamba.git

libcli/auth: return INVALID_PARAMETER for DES in netlogon_creds_{de,en}crypt_samlogon_logon

For the NetlogonGenericInformation case we want an error instead of no
encryption if only DES was negotiated...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15425

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/libcli/auth/credentials.c b/libcli/auth/credentials.c
index d9ba349ef70..93a537c2b01 100644
--- a/libcli/auth/credentials.c
+++ b/libcli/auth/credentials.c
@@ -1120,6 +1120,7 @@ static NTSTATUS netlogon_creds_crypt_samlogon_logon(struct netlogon_creds_Creden
 			}
 		} else {
 			/* Using DES to verify kerberos tickets makes no sense */
+			return NT_STATUS_INVALID_PARAMETER;
 		}
 		break;
 	}