From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 8 Nov 2021 12:30:55 +0000 (+0100)
Subject: examples/dommigrate: Don't set retval in usage()
X-Git-Tag: v7.10.0-rc1~135
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=132069f845b67cc45715c081527950a4e03e2a47;p=thirdparty%2Flibvirt.git

examples/dommigrate: Don't set retval in usage()

The usage() function should just print expected arguments. Make
the function return void then.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Kristína Hanicová <khanicov@redhat.com>
---

diff --git a/examples/c/domain/dommigrate.c b/examples/c/domain/dommigrate.c
index 60cfb3fb83..b1641efb9a 100644
--- a/examples/c/domain/dommigrate.c
+++ b/examples/c/domain/dommigrate.c
@@ -26,11 +26,10 @@
 #include <libvirt/virterror.h>
 
 
-static int
-usage(char *prgn, int ret)
+static void
+usage(char *prgn)
 {
     printf("Usage: %s <src uri> <dst uri> <domain name>\n", prgn);
-    return ret;
 }
 
 int
@@ -42,7 +41,7 @@ main(int argc, char *argv[])
     virDomainPtr dom = NULL;
 
     if (argc < 4) {
-        ret = usage(argv[0], 1);
+        usage(argv[0]);
         goto out;
     }