From: Donghwa Jeong Date: Mon, 28 May 2018 04:42:45 +0000 (+0900) Subject: network: fix socket handle leak X-Git-Tag: lxc-2.0.10~122 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1322cb60d95efa0bc5663581b1558c11b33a789e;p=thirdparty%2Flxc.git network: fix socket handle leak Signed-off-by: Donghwa Jeong --- diff --git a/src/lxc/network.c b/src/lxc/network.c old mode 100644 new mode 100755 index 863bb9635..a262693e5 --- a/src/lxc/network.c +++ b/src/lxc/network.c @@ -1946,7 +1946,12 @@ int setup_private_host_hw_addr(char *veth1) if (sockfd < 0) return -errno; - snprintf((char *)ifr.ifr_name, IFNAMSIZ, "%s", veth1); + err = snprintf((char *)ifr.ifr_name, IFNAMSIZ, "%s", veth1); + if (err < 0 || (size_t)err >= IFNAMSIZ) { + close(sockfd); + return -E2BIG; + } + err = ioctl(sockfd, SIOCGIFHWADDR, &ifr); if (err < 0) { close(sockfd);