From: Shyam Saini Date: Wed, 21 Jun 2017 08:47:45 +0000 (+0530) Subject: tests: py: Fail test forcefully when bug is not fixed X-Git-Tag: v0.8~129 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1325419d43184ffe426878af2a2f050e28702852;p=thirdparty%2Fnftables.git tests: py: Fail test forcefully when bug is not fixed When we have "fail" in the test cases then py test doesn't complain anything, but the test should complain if the fix is not applied. Before applying 986dea8a4a9d ("evaluate: avoid reference to multiple src data in statements which set values"), nft throws following error message and exits with error code 134. $ nft add rule x y tcp dport set { 0 , 1 } BUG: unknown expression type set reference nft: netlink_linearize.c:696: netlink_gen_expr: Assertion `0' failed. Aborted This commit enforces nft-test.py to throw error message when the fix is not applied. Signed-off-by: Shyam Saini Signed-off-by: Pablo Neira Ayuso --- diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py index c1da71aaf..8d099a15a 100755 --- a/tests/py/nft-test.py +++ b/tests/py/nft-test.py @@ -702,7 +702,7 @@ def rule_add(rule, filename, lineno, force_all_family_option, filename_path): ret = execute_cmd(cmd, filename, lineno, payload_log) state = rule[1].rstrip() - if (ret == 0 and state == "fail") or (ret != 0 and state == "ok"): + if (ret in [0,134] and state == "fail") or (ret != 0 and state == "ok"): if state == "fail": test_state = "This rule should have failed." else: