From: mkanat%bugzilla.org <>
Date: Mon, 28 Jan 2008 01:39:28 +0000 (+0000)
Subject: Bug 410521: The diffs in bugmails were broken and BugMail.pm was throwing a warning... 
X-Git-Tag: bugzilla-3.1.3~355
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=132fcaa16d4035e3551a75c63d4de23dc11bb835;p=thirdparty%2Fbugzilla.git

Bug 410521: The diffs in bugmails were broken and BugMail.pm was throwing a warning about sprintf.
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
---

diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm
index b8680e10b0..1085c8b935 100644
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -71,7 +71,7 @@ sub multiline_sprintf {
     my ($format, $args, $sizes) = @_;
     my @parts;
     my @my_sizes = @$sizes; # Copy this so we don't modify the input array.
-    while (my $string = shift @$args) {
+    foreach my $string (@$args) {
         my $size = shift @my_sizes;
         my @pieces = split("\n", wrap_hard($string, $size));
         push(@parts, \@pieces);