From: Frédéric Buclin <LpSolit@gmail.com>
Date: Thu, 25 Sep 2014 22:08:34 +0000 (+0200)
Subject: Bug 1071033: Variable "$user" will not stay shared at buglist.cgi
X-Git-Tag: bugzilla-4.5.6~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=135afc0a669578ca4ca8188c580acb2faadf5472;p=thirdparty%2Fbugzilla.git

Bug 1071033: Variable "$user" will not stay shared at buglist.cgi
r=dkl a=sgreen
---

diff --git a/buglist.cgi b/buglist.cgi
index c04c7853fe..5e84b340b0 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -283,6 +283,7 @@ sub GetGroups {
 
 sub _get_common_flag_types {
     my $component_ids = shift;
+    my $user = Bugzilla->user;
 
     # Get all the different components in the bug list
     my $components = Bugzilla::Component->new_from_list($component_ids);
@@ -303,12 +304,10 @@ sub _get_common_flag_types {
             if $flag_type_count == scalar @$components;
     }
 
-    # We only show flags that a user has request or set rights on
+    # We only show flags that a user can request.
     my @show_flag_types
-        = grep { $user->can_request_flag($_) || $user->can_set_flag($_) }
-        values %common_flag_types;
-    my $any_flags_requesteeble =
-        grep($_->is_requesteeble, @show_flag_types);
+        = grep { $user->can_request_flag($_) } values %common_flag_types;
+    my $any_flags_requesteeble = grep { $_->is_requesteeble } @show_flag_types;
 
     return(\@show_flag_types, $any_flags_requesteeble);
 }