From: Pádraig Brady <P@draigBrady.com>
Date: Thu, 13 Mar 2014 01:32:46 +0000 (+0000)
Subject: chroot: always diagnose failure to set supplemental groups
X-Git-Tag: v8.23~114
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=137a4239751802b7d59ac3ef9c42fbe03547b2bc;p=thirdparty%2Fcoreutils.git

chroot: always diagnose failure to set supplemental groups

* src/chroot.c (setgroups): Change this replacement to
fail when called so that platforms like Interix without support for
supplemental groups don't silently ignore a --groups option.
---

diff --git a/src/chroot.c b/src/chroot.c
index 36912a5d35..8b08b84ea1 100644
--- a/src/chroot.c
+++ b/src/chroot.c
@@ -54,13 +54,12 @@ static struct option const long_opts[] =
 };
 
 #if ! HAVE_SETGROUPS
-/* At least Interix lacks supplemental group support.  Define an
-   always-successful replacement to avoid checking for setgroups
-   availability everywhere, just to support broken platforms. */
+/* At least Interix lacks supplemental group support.  */
 static int
 setgroups (size_t size _GL_UNUSED, gid_t const *list _GL_UNUSED)
 {
-  return 0;
+  errno = ENOTSUP;
+  return -1;
 }
 #endif