From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Mon, 27 Oct 2025 10:05:54 +0000 (+0100)
Subject: Revert the actual move to C++, but keep all the other changes
X-Git-Tag: rec-5.4.0-alpha1~100^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=13a2f2b0512cfb2b0484da6a1becbbc91625f52f;p=thirdparty%2Fpdns.git

Revert the actual move to C++, but keep all the other changes

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/builder-support/specs/dnsdist.spec b/builder-support/specs/dnsdist.spec
index 2561c39797..9439dd38fd 100644
--- a/builder-support/specs/dnsdist.spec
+++ b/builder-support/specs/dnsdist.spec
@@ -19,7 +19,8 @@ BuildRequires: systemd-units
 BuildRequires: systemd-devel
 %endif
 
-%if 0%{?rhel} == 8
+# Only when we move to C++20
+%if 0%{?rhel} == 8 && 0
 BuildRequires: boost1.78-devel
 %else
 BuildRequires: boost-devel
@@ -74,7 +75,8 @@ dnsdist is a high-performance DNS loadbalancer that is scriptable in Lua.
 
 %build
 # We need to build with LLVM/clang to be able to use LTO, since we are linking against a static Rust library built with LLVM
-%if 0%{?rhel} == 8
+# Only when we move to C++20
+%if 0%{?rhel} == 8 && 0
 export BOOST_INCLUDEDIR=/usr/include/boost1.78
 export BOOST_LIBRARYDIR=/usr/lib64/boost1.78
 %endif
diff --git a/builder-support/specs/pdns.spec b/builder-support/specs/pdns.spec
index 2bb54d85f8..38975383c7 100644
--- a/builder-support/specs/pdns.spec
+++ b/builder-support/specs/pdns.spec
@@ -20,7 +20,8 @@ BuildRequires: systemd-devel
 BuildRequires: krb5-devel
 BuildRequires: p11-kit-devel
 BuildRequires: libcurl-devel
-%if 0%{?rhel} == 8
+# Only when we move to C++20
+%if 0%{?rhel} == 8 && 0
 BuildRequires: boost1.78-devel
 %else
 BuildRequires: boost-devel
@@ -176,7 +177,8 @@ This package contains the ixfrdist program.
 %autosetup -p1 -n %{name}-%{getenv:BUILDER_VERSION}
 
 %build
-%if 0%{?rhel} == 8
+# Only when we move to C++20
+%if 0%{?rhel} == 8 && 0
 export BOOST_INCLUDEDIR=/usr/include/boost1.78
 export BOOST_LIBRARYDIR=/usr/lib64/boost1.78
 export CPPFLAGS=-I$BOOST_INCLUDEDIR
diff --git a/configure.ac b/configure.ac
index 3e4177cea5..c2f969a795 100644
--- a/configure.ac
+++ b/configure.ac
@@ -35,7 +35,7 @@ PDNS_CHECK_FLEX
 # Warn when pkg.m4 is missing
 m4_pattern_forbid([^_?PKG_[A-Z_]+$], [*** pkg.m4 missing, please install pkg-config])
 
-AX_CXX_COMPILE_STDCXX_20([ext], [mandatory])
+AX_CXX_COMPILE_STDCXX_17([noext], [mandatory])
 LT_PREREQ([2.2.2])
 LT_INIT([disable-static dlopen])
 
diff --git a/meson.build b/meson.build
index 5736de86d3..695e50eb73 100644
--- a/meson.build
+++ b/meson.build
@@ -8,7 +8,7 @@ project(
   default_options: [
     'buildtype=debugoptimized',
     'warning_level=2',          # TODO Move this to 3 to enable -Wpedantic
-    'cpp_std=gnu++20',
+    'cpp_std=c++17',
   ],
 )
 
diff --git a/pdns/distributor.hh b/pdns/distributor.hh
index fb18019b7d..cdee87b67d 100644
--- a/pdns/distributor.hh
+++ b/pdns/distributor.hh
@@ -173,7 +173,7 @@ template<class Answer, class Question, class Backend>MultiThreadDistributor<Answ
   g_log<<Logger::Warning<<"About to create "<<numberOfThreads<<" backend threads for UDP"<<endl;
 
   for (int distributorIdx = 0; distributorIdx < numberOfThreads; distributorIdx++) {
-    std::thread t([=,this](){distribute(distributorIdx);});
+    std::thread t([=](){distribute(distributorIdx);});
     t.detach();
     Utility::usleep(50000); // we've overloaded mysql in the past :-)
   }
diff --git a/pdns/dnsdistdist/configure.ac b/pdns/dnsdistdist/configure.ac
index 00fea50383..2297d1a78b 100644
--- a/pdns/dnsdistdist/configure.ac
+++ b/pdns/dnsdistdist/configure.ac
@@ -148,7 +148,7 @@ PDNS_CHECK_LMDB
 PDNS_ENABLE_IPCIPHER
 PDNS_CHECK_AARCH64_UINT64X2_T
 
-AX_CXX_COMPILE_STDCXX_20([ext], [mandatory])
+AX_CXX_COMPILE_STDCXX_17([noext], [mandatory])
 
 AC_MSG_CHECKING([whether we will enable compiler security checks])
 AC_ARG_ENABLE([hardening],
diff --git a/pdns/dnsdistdist/dnsdist-rust-lib/rust/build.rs b/pdns/dnsdistdist/dnsdist-rust-lib/rust/build.rs
index a3a0bb3e4f..26bdbc13c1 100644
--- a/pdns/dnsdistdist/dnsdist-rust-lib/rust/build.rs
+++ b/pdns/dnsdistdist/dnsdist-rust-lib/rust/build.rs
@@ -5,7 +5,7 @@ use std::env;
 fn main() {
     let mut bridge = cxx_build::bridge("src/lib.rs");
     let mut build = bridge
-            .flag_if_supported("-std=c++17")
+            .std("c++17")
             .flag("-Isrc")
             .flag("-I.")
             .flag("-I..")
@@ -23,4 +23,4 @@ fn main() {
 
     println!("cargo:rerun-if-changed=src/lib.rs");
     println!("cargo:rerun-if-changed=src/helpers.rs");
-}
\ No newline at end of file
+}
diff --git a/pdns/dnsdistdist/meson.build b/pdns/dnsdistdist/meson.build
index 84c59f5926..69e42d5b3b 100644
--- a/pdns/dnsdistdist/meson.build
+++ b/pdns/dnsdistdist/meson.build
@@ -8,7 +8,7 @@ project(
   default_options: [
     'buildtype=debugoptimized',
     'warning_level=2',          # TODO Move this to 3 to enable -Wpedantic
-    'cpp_std=gnu++20',
+    'cpp_std=c++17',
     'b_pie=true',
   ],
 )
diff --git a/pdns/recursordist/configure.ac b/pdns/recursordist/configure.ac
index 27bdcf1965..4e79b21646 100644
--- a/pdns/recursordist/configure.ac
+++ b/pdns/recursordist/configure.ac
@@ -32,7 +32,7 @@ CPPFLAGS="-DRECURSOR $CPPFLAGS"
 # Warn when pkg.m4 is missing
 m4_pattern_forbid([^_?PKG_[A-Z_]+$], [*** pkg.m4 missing, please install pkg-config])
 
-AX_CXX_COMPILE_STDCXX_20([ext], [mandatory])
+AX_CXX_COMPILE_STDCXX_17([noext], [mandatory])
 PDNS_CHECK_CARGO([1.64])
 
 # Rust runtime used dlopen from its static lib
diff --git a/pdns/recursordist/meson.build b/pdns/recursordist/meson.build
index 0f64b83c82..84d75a38c8 100644
--- a/pdns/recursordist/meson.build
+++ b/pdns/recursordist/meson.build
@@ -8,7 +8,7 @@ project(
   default_options: [
     'buildtype=debugoptimized',
     'warning_level=2',          # TODO Move this to 3 to enable -Wpedantic
-    'cpp_std=gnu++20',
+    'cpp_std=c++17',
   ],
 )
 
diff --git a/pdns/recursordist/rec-rust-lib/rust/build.rs b/pdns/recursordist/rec-rust-lib/rust/build.rs
index 37b6efe258..2f2e1b541d 100644
--- a/pdns/recursordist/rec-rust-lib/rust/build.rs
+++ b/pdns/recursordist/rec-rust-lib/rust/build.rs
@@ -2,7 +2,7 @@ fn main() {
     let sources = vec!["src/lib.rs", "src/web.rs", "src/misc.rs"];
     cxx_build::bridges(sources)
         // .file("src/source.cc") Code callable from Rust is in ../cxxsupport.cc
-        .flag_if_supported("-std=c++17")
+        .std("c++17")
         .flag("-Isrc")
         .flag("-I../..")
         .compile("recrust");