From: Xiao Ni <xni@redhat.com>
Date: Fri, 26 Jul 2024 07:14:05 +0000 (+0800)
Subject: mdadm/Grow: fix coverity issue STRING_OVERFLOW
X-Git-Tag: mdadm-4.4~108
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=13c1f4a56b3bedbf802d66e86afd787e318e25fb;p=thirdparty%2Fmdadm.git

mdadm/Grow: fix coverity issue STRING_OVERFLOW

Fix string overflow problems in Grow.c

Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
---

diff --git a/Grow.c b/Grow.c
index 907a6e1b..a5f9027d 100644
--- a/Grow.c
+++ b/Grow.c
@@ -1694,7 +1694,7 @@ char *analyse_change(char *devname, struct mdinfo *info, struct reshape *re)
 					/* Current RAID6 layout has a RAID5
 					 * equivalent - good
 					 */
-					strcat(strcpy(layout, ls), "-6");
+					snprintf(layout, 40, "%s-6", ls);
 					l = map_name(r6layout, layout);
 					if (l == UnSet)
 						return "Cannot find RAID6 layout to convert to";