From: Benjamin Drung <benjamin.drung@canonical.com>
Date: Sat, 7 Feb 2026 22:57:44 +0000 (+0100)
Subject: test: introduce make_client_rootfs/make_server_rootfs
X-Git-Tag: 110~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=13c5621d0f5deee5e2aea919a5b30ce1b75394f5;p=thirdparty%2Fdracut-ng.git

test: introduce make_client_rootfs/make_server_rootfs

Test 72 NBD has the helper functions `make_client_rootfs` and
`make_server_rootfs` which makes the test easier to read.

Refactor the other tests and introduce the helper functions
`make_client_rootfs` and `make_server_rootfs` there as well.
---

diff --git a/test/TEST-60-NFS/test.sh b/test/TEST-60-NFS/test.sh
index 75979f2da..a3b1318ac 100755
--- a/test/TEST-60-NFS/test.sh
+++ b/test/TEST-60-NFS/test.sh
@@ -215,7 +215,7 @@ test_run() {
     fi
 }
 
-test_setup() {
+make_server_rootfs() {
     call_dracut --tmpdir "$TESTDIR" \
         --add-confdir test-root \
         -a "$USE_NETWORK url-lib nfs" \
@@ -255,6 +255,10 @@ test_setup() {
     inst_init ./client-init.sh "$initdir"
 
     build_ext4_image "$TESTDIR/server-rootfs" "$TESTDIR"/server.img dracut
+}
+
+test_setup() {
+    make_server_rootfs
 
     # Make client's dracut image
     test_dracut \
diff --git a/test/TEST-70-ISCSI/test.sh b/test/TEST-70-ISCSI/test.sh
index 6644eb1b4..c157d710c 100755
--- a/test/TEST-70-ISCSI/test.sh
+++ b/test/TEST-70-ISCSI/test.sh
@@ -121,8 +121,7 @@ test_check() {
     fi
 }
 
-test_setup() {
-    # Create client root filesystem
+make_client_rootfs() {
     build_client_rootfs "$TESTDIR/overlay/source"
     inst_multiple ip grep setsid
     mkdir -p -- "$TESTDIR"/overlay/source/var/lib/nfs/rpc_pipefs
@@ -153,8 +152,9 @@ test_setup() {
         -initrd "$TESTDIR"/initramfs.makeroot
     test_marker_check dracut-root-block-created
     rm -- "$TESTDIR"/marker.img
+}
 
-    # Create server root filesystem
+make_server_rootfs() {
     call_dracut --tmpdir "$TESTDIR" \
         --add-confdir test-root \
         -a "$USE_NETWORK" \
@@ -172,6 +172,11 @@ test_setup() {
 
     build_ext4_image "$TESTDIR/server-rootfs" "$TESTDIR"/server.img dracut
     rm -rf "$TESTDIR"/server-rootfs
+}
+
+test_setup() {
+    make_client_rootfs
+    make_server_rootfs
 
     # Make server's dracut image
     call_dracut \
diff --git a/test/TEST-71-ISCSI-MULTI/test.sh b/test/TEST-71-ISCSI-MULTI/test.sh
index 0421f3998..22a0a66b8 100755
--- a/test/TEST-71-ISCSI-MULTI/test.sh
+++ b/test/TEST-71-ISCSI-MULTI/test.sh
@@ -129,8 +129,7 @@ test_check() {
     fi
 }
 
-test_setup() {
-    # Create client root filesystem
+make_client_rootfs() {
     rm -rf -- "$TESTDIR"/overlay
     build_client_rootfs "$TESTDIR/overlay/source"
     inst_multiple ip grep setsid
@@ -162,8 +161,9 @@ test_setup() {
         -initrd "$TESTDIR"/initramfs.makeroot
     test_marker_check dracut-root-block-created
     rm -- "$TESTDIR"/marker.img
+}
 
-    # Create server root filesystem
+make_server_rootfs() {
     call_dracut --tmpdir "$TESTDIR" \
         --add-confdir test-root \
         -a "$USE_NETWORK iscsi" \
@@ -182,6 +182,11 @@ test_setup() {
 
     build_ext4_image "$TESTDIR/server-rootfs" "$TESTDIR"/server.img dracut
     rm -rf "$TESTDIR"/server-rootfs
+}
+
+test_setup() {
+    make_client_rootfs
+    make_server_rootfs
 
     # Make client's dracut image
     test_dracut \