From: Jim Fehlig <jfehlig@suse.com>
Date: Fri, 16 Mar 2018 21:22:45 +0000 (-0600)
Subject: libxl: call EndJob in error case
X-Git-Tag: v4.2.0-rc1~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=13e81fc6fad03aa6b6ecf4230f44b2ea55078229;p=thirdparty%2Flibvirt.git

libxl: call EndJob in error case

If starting the domain fails in libxlDomainCreateXML, we mistakenly
jumped to cleanup without calling libxlDomainObjEndJob. Remove the
jump to 'cleanup'.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index ac61fb3221..3ebeacca81 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -1066,7 +1066,6 @@ libxlDomainCreateXML(virConnectPtr conn, const char *xml,
         if (!vm->persistent) {
             virDomainObjListRemove(driver->domains, vm);
             virObjectLock(vm);
-            goto cleanup;
         }
         goto endjob;
     }