From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 5 Mar 2020 08:25:35 +0000 (+0100)
Subject: virLXCProcessSetupNamespaceName: Fix potential uninitialized free of 'path'
X-Git-Tag: v6.2.0-rc1~270
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=140c756f5ca598b5640d3a5342e8914e7f88bc9b;p=thirdparty%2Flibvirt.git

virLXCProcessSetupNamespaceName: Fix potential uninitialized free of 'path'

'path' could be accessed uninitialized. Fix it by using g_autofree which
also mandates initialization.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 0277ba8b62..cd0026f78f 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -409,7 +409,7 @@ static int virLXCProcessSetupNamespaceName(virLXCDriverPtr driver,
     int fd = -1;
     virDomainObjPtr vm;
     virLXCDomainObjPrivatePtr priv;
-    char *path;
+    g_autofree char *path = NULL;
 
     vm = virDomainObjListFindByName(driver->domains, name);
     if (!vm) {
@@ -436,7 +436,6 @@ static int virLXCProcessSetupNamespaceName(virLXCDriverPtr driver,
     }
 
  cleanup:
-    VIR_FREE(path);
     virDomainObjEndAPI(&vm);
     return fd;
 }