From: Axel Lin Date: Wed, 15 Jun 2016 02:21:34 +0000 (+0800) Subject: regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed X-Git-Tag: v4.6.7~36 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=141c47d95f6d09478fe53bcbb54c3155dc6de888;p=thirdparty%2Fkernel%2Fstable.git regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed commit 43160ffd12c8d1d331362362eea3c70e04b6f9c4 upstream. Use regulator_list_voltage_linear_range in rpm_smps_ldo_ops_fixed is wrong because it is used for fixed regulator without any linear range. The rpm_smps_ldo_ops_fixed is used for pm8941_lnldo which has fixed_uV set and n_voltages = 1. In this case, regulator_list_voltage() can return rdev->desc->fixed_uV without .list_voltage implementation. Fixes: 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback") Signed-off-by: Axel Lin Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c index 6c7fe47787937..7e156a0b65dd9 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -140,7 +140,6 @@ static const struct regulator_ops rpm_smps_ldo_ops = { .enable = rpm_reg_enable, .disable = rpm_reg_disable, .is_enabled = rpm_reg_is_enabled, - .list_voltage = regulator_list_voltage_linear_range, .get_voltage = rpm_reg_get_voltage, .set_voltage = rpm_reg_set_voltage,