From: Matthew Wilcox (Oracle) Date: Wed, 5 Mar 2025 20:47:27 +0000 (+0000) Subject: orangefs: make open_for_read and open_for_write boolean X-Git-Tag: v6.15-rc1~239^2^2~6 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=144fa8ae0830280a1d9b53e80f55b8c51260a4ab;p=thirdparty%2Fkernel%2Flinux.git orangefs: make open_for_read and open_for_write boolean sparse currently warns: fs/orangefs/file.c:119:32: warning: incorrect type in assignment (different base types) fs/orangefs/file.c:119:32: expected int open_for_write fs/orangefs/file.c:119:32: got restricted fmode_t Turning open_for_write and open_for_read into booleans (which is how they're used) removes this warning. Signed-off-by: "Matthew Wilcox (Oracle)" Link: https://lore.kernel.org/r/20250305204734.1475264-4-willy@infradead.org Tested-by: Mike Marshall Signed-off-by: Christian Brauner --- diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c index d68372241b30b..90c49c0de243f 100644 --- a/fs/orangefs/file.c +++ b/fs/orangefs/file.c @@ -57,8 +57,8 @@ ssize_t wait_for_direct_io(enum ORANGEFS_io_type type, struct inode *inode, int buffer_index; ssize_t ret; size_t copy_amount; - int open_for_read; - int open_for_write; + bool open_for_read; + bool open_for_write; new_op = op_alloc(ORANGEFS_VFS_OP_FILE_IO); if (!new_op)