From: Pauli <ppzgs1@gmail.com>
Date: Wed, 17 Mar 2021 01:41:48 +0000 (+1000)
Subject: modes: fix coverity 1449860: overlapping memory copy
X-Git-Tag: openssl-3.0.0-alpha14~218
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=145f12d12dc83c737676883c625c2a95d34251ed;p=thirdparty%2Fopenssl.git

modes: fix coverity 1449860: overlapping memory copy

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14584)
---

diff --git a/crypto/modes/cbc128.c b/crypto/modes/cbc128.c
index 9ac9299f658..86dd781c551 100644
--- a/crypto/modes/cbc128.c
+++ b/crypto/modes/cbc128.c
@@ -69,7 +69,8 @@ void CRYPTO_cbc128_encrypt(const unsigned char *in, unsigned char *out,
         in += 16;
         out += 16;
     }
-    memcpy(ivec, iv, 16);
+    if (ivec != iv)
+        memcpy(ivec, iv, 16);
 }
 
 void CRYPTO_cbc128_decrypt(const unsigned char *in, unsigned char *out,