From: Jim Meyering <meyering@redhat.com>
Date: Fri, 4 Sep 2009 09:20:23 +0000 (+0200)
Subject: qemu_conf.c: add a comment suggesting why we leave a dead-store
X-Git-Tag: v0.7.1~82
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1469bcf6c5f4859ae6601ca91689106668a04e7a;p=thirdparty%2Flibvirt.git

qemu_conf.c: add a comment suggesting why we leave a dead-store

* src/qemu_conf.c (qemuBuildHostNetStr): Do not remove the type_sep=','
dead store, since not having it would be a problem if we ever add a
new attribute=VAL option.
---

diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index c6b4184ab0..caf518c1ce 100644
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -1272,7 +1272,7 @@ qemuBuildHostNetStr(virConnectPtr conn,
             if (net->hostnet_name) {
                 virBufferVSprintf(&buf, "%cname=%s", type_sep,
                                   net->hostnet_name);
-                type_sep = ',';
+                type_sep = ','; /* dead-store, but leave it, in case... */
             }
             if (virBufferError(&buf)) {
                 virReportOOMError(conn);