From: Razvan Becheriu <razvan@isc.org>
Date: Tue, 24 Aug 2021 10:17:25 +0000 (+0300)
Subject: [#1982] added unittests
X-Git-Tag: Kea-1.9.11~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=148dfb60061bf874930d10b22bc95fe06a12e126;p=thirdparty%2Fkea.git

[#1982] added unittests
---

diff --git a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
index aed276db0e..2e23ed8395 100644
--- a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
+++ b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
@@ -591,6 +591,7 @@ TEST_F(MySqlConfigBackendDHCPv4Test, getType) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv4(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("mysql", cbptr_->getType());
 }
 
@@ -602,6 +603,7 @@ TEST_F(MySqlConfigBackendDHCPv4Test, getHost) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv4(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("localhost", cbptr_->getHost());
 }
 
@@ -612,6 +614,7 @@ TEST_F(MySqlConfigBackendDHCPv4Test, getPort) {
     params["name"] = "keatest";
     params["password"] = "keatest";
     params["user"] = "keatest";
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv4(params)));
     EXPECT_EQ(0, cbptr_->getPort());
 }
diff --git a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc
index 7a6acf33f4..2fc311446a 100644
--- a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc
+++ b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc
@@ -634,6 +634,7 @@ TEST_F(MySqlConfigBackendDHCPv6Test, getType) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv6(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("mysql", cbptr_->getType());
 }
 
@@ -645,6 +646,7 @@ TEST_F(MySqlConfigBackendDHCPv6Test, getHost) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv6(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("localhost", cbptr_->getHost());
 }
 
@@ -656,6 +658,7 @@ TEST_F(MySqlConfigBackendDHCPv6Test, getPort) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv6(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ(0, cbptr_->getPort());
 }
 
diff --git a/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc b/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc
index 26732a9f6a..217f4e39ba 100644
--- a/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc
+++ b/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc
@@ -207,6 +207,7 @@ GenericHostDataSourceTest::testReadOnlyDatabase(const char* valid_db_type) {
         VALID_PASSWORD, VALID_READONLY_DB));
 
     hdsptr_ = HostMgr::instance().getHostDataSource();
+    ASSERT_NE(hdsptr_->getParameters(), DatabaseConnection::ParameterMap());
 
     // Check that an attempt to insert new host would result in
     // exception.