From: Nick Porter <nick@portercomputing.co.uk>
Date: Tue, 22 Jul 2025 13:29:04 +0000 (+0100)
Subject: Correct assert on timer being disarmed
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14923fe712d3dacf0ded72a6381b0819ddcb7cdf;p=thirdparty%2Ffreeradius-server.git

Correct assert on timer being disarmed
---

diff --git a/src/modules/rlm_tacacs/rlm_tacacs_tcp.c b/src/modules/rlm_tacacs/rlm_tacacs_tcp.c
index f7c3258c84..a6512ce0ca 100644
--- a/src/modules/rlm_tacacs/rlm_tacacs_tcp.c
+++ b/src/modules/rlm_tacacs/rlm_tacacs_tcp.c
@@ -1263,7 +1263,7 @@ static void request_complete(request_t *request, NDEBUG_UNUSED void *preq, void
 	tcp_request_t		*req = talloc_get_type_abort(preq, tcp_request_t);
 #endif
 
-	fr_assert(!req->packet && !req->ev);	/* Dealt with by request_conn_release */
+	fr_assert(!req->packet && !fr_timer_armed(req->ev));	/* Dealt with by request_conn_release */
 
 	r->treq = NULL;
 
@@ -1277,7 +1277,7 @@ static void request_free(UNUSED request_t *request, void *preq_to_free, UNUSED v
 {
 	tcp_request_t		*req = talloc_get_type_abort(preq_to_free, tcp_request_t);
 
-	fr_assert(!req->packet && !req->ev);	/* Dealt with by request_conn_release */
+	fr_assert(!req->packet && !fr_timer_armed(req->ev));	/* Dealt with by request_conn_release */
 
 	talloc_free(req);
 }