From: Jeremy Allison <jra@samba.org>
Date: Tue, 21 Jul 2020 00:27:13 +0000 (-0700)
Subject: s3: libsmb: Cleanup - use helper 'ok' bool for internal_resolve_name().
X-Git-Tag: talloc-2.3.2~961
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1499fd8a2e5eee8d515000e4059063215db10e3c;p=thirdparty%2Fsamba.git

s3: libsmb: Cleanup - use helper 'ok' bool for internal_resolve_name().

No logic change.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 507ee1d6a70..314484e48d5 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -2613,8 +2613,9 @@ NTSTATUS internal_resolve_name(const char *name,
 		(*return_iplist)->port = PORT_NONE;
 
 		/* if it's in the form of an IP address then get the lib to interpret it */
-		if (!interpret_string_addr(&(*return_iplist)->ss,
-					name, AI_NUMERICHOST)) {
+		ok = interpret_string_addr(&(*return_iplist)->ss,
+					name, AI_NUMERICHOST);
+		if (!ok) {
 			DEBUG(1,("internal_resolve_name: interpret_string_addr "
 				"failed on %s\n",
 				name));