From: Bob Halley <halley@dnspython.org>
Date: Mon, 4 Jan 2021 20:17:36 +0000 (-0800)
Subject: _WireReader.read() should make flags a dns.flags.Flag [Issue #606]
X-Git-Tag: v2.1.0~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14bbb9ce8865dd41465f85a1fce23989b5cb3cd0;p=thirdparty%2Fdnspython.git

_WireReader.read() should make flags a dns.flags.Flag [Issue #606]
---

diff --git a/dns/message.py b/dns/message.py
index 428c98e0..ac888379 100644
--- a/dns/message.py
+++ b/dns/message.py
@@ -990,7 +990,7 @@ class _WireReader:
             self.parser.get_struct('!HHHHHH')
         factory = _message_factory_from_opcode(dns.opcode.from_flags(flags))
         self.message = factory(id=id)
-        self.message.flags = flags
+        self.message.flags = dns.flags.Flag(flags)
         self.initialize_message(self.message)
         self.one_rr_per_rrset = \
             self.message._get_one_rr_per_rrset(self.one_rr_per_rrset)
diff --git a/tests/test_message.py b/tests/test_message.py
index ed48e7bd..19738e67 100644
--- a/tests/test_message.py
+++ b/tests/test_message.py
@@ -676,6 +676,11 @@ flags QR
             IN SOA
 ''')
 
+    def test_from_wire_makes_Flag(self):
+        m = dns.message.from_wire(goodwire)
+        self.assertIsInstance(m.flags, dns.flags.Flag)
+        self.assertEqual(m.flags, dns.flags.Flag.RD)
+
 
 if __name__ == '__main__':
     unittest.main()