From: Michal Privoznik <mprivozn@redhat.com>
Date: Fri, 27 May 2022 14:59:54 +0000 (+0200)
Subject: qemuProcessStop: Don't try to remove QoS on already removed TAP
X-Git-Tag: v8.4.0-rc2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14bd5036e4195d402e956e953a08183b17888b8f;p=thirdparty%2Flibvirt.git

qemuProcessStop: Don't try to remove QoS on already removed TAP

When cleaning up after stopped domain, one of the things we do is
attempt to clear QoS settings on OVS type interfaces. Well, this
is needless because they were removed just a couple of lines
above. As a result, the attempt fails and a warning is printed
into logs, polluting them needlessly.

Closes: https://gitlab.com/libvirt/libvirt/-/issues/313
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 07acb1c427..c6d965d720 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8166,12 +8166,6 @@ void qemuProcessStop(virQEMUDriver *driver,
             else
                 VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname));
         }
-
-        if (virDomainNetDefIsOvsport(net) &&
-            virNetDevOpenvswitchInterfaceClearQos(net->ifname, vm->def->uuid) < 0) {
-            VIR_WARN("cannot clear bandwidth setting for ovs device : %s",
-                     net->ifname);
-        }
     }
 
  retry: