From: Victor Julien <victor@inliniac.net>
Date: Fri, 23 Dec 2016 14:17:19 +0000 (+0100)
Subject: detect: remove unused state file flag
X-Git-Tag: suricata-4.0.0-beta1~336
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14ced15e3662b5b49a1d1325d7997884f3fe37f7;p=thirdparty%2Fsuricata.git

detect: remove unused state file flag
---

diff --git a/src/detect-engine-state.c b/src/detect-engine-state.c
index 8a860e982f..e25accf3fd 100644
--- a/src/detect-engine-state.c
+++ b/src/detect-engine-state.c
@@ -311,7 +311,6 @@ static void StoreStateTxHandleFiles(DetectEngineThreadCtx *det_ctx, Flow *f,
     DeStateStoreFileNoMatchCnt(destate, file_no_match, flags);
     if (DeStateStoreFilestoreSigsCantMatch(det_ctx->sgh, destate, flags) == 1) {
         FileDisableStoringForTransaction(f, flags & (STREAM_TOCLIENT | STREAM_TOSERVER), tx_id);
-        destate->dir_state[flags & STREAM_TOSERVER ? 0 : 1].flags |= DETECT_ENGINE_STATE_FLAG_FILE_STORE_DISABLED;
     }
 }
 
diff --git a/src/detect-engine-state.h b/src/detect-engine-state.h
index d1b789da72..9c46d84ef4 100644
--- a/src/detect-engine-state.h
+++ b/src/detect-engine-state.h
@@ -59,10 +59,13 @@
 /* first bit position after the built-ins */
 #define DE_STATE_FLAG_BASE                      4UL
 
-/* state flags */
-#define DETECT_ENGINE_STATE_FLAG_FILE_STORE_DISABLED 0x0001
-#define DETECT_ENGINE_STATE_FLAG_FILE_TC_NEW         0x0002
-#define DETECT_ENGINE_STATE_FLAG_FILE_TS_NEW         0x0004
+/* state flags
+ *
+ * Used by app-layer-parsers to notify us that new files
+ * are available in the tx.
+ */
+#define DETECT_ENGINE_STATE_FLAG_FILE_TC_NEW    BIT_U8(0)
+#define DETECT_ENGINE_STATE_FLAG_FILE_TS_NEW    BIT_U8(1)
 
 /* We have 2 possible state values to be used by ContinueDetection() while
  * trying to figure if we have fresh state to install or not.