From: Yann Collet <cyan@fb.com>
Date: Fri, 31 Mar 2023 20:09:52 +0000 (-0700)
Subject: do not add invocation of UTIL_isRegularFile()
X-Git-Tag: v1.5.5~2^2~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14d0cd5d690ef0956a2e3085e81c78578f55b81e;p=thirdparty%2Fzstd.git

do not add invocation of UTIL_isRegularFile()
---

diff --git a/programs/fileio.c b/programs/fileio.c
index 877460302..4f75ff474 100644
--- a/programs/fileio.c
+++ b/programs/fileio.c
@@ -581,6 +581,8 @@ FIO_openDstFile(FIO_ctx_t* fCtx, FIO_prefs_t* const prefs,
                 const char* srcFileName, const char* dstFileName,
                 const int mode)
 {
+    int isDstRegFile;
+
     if (prefs->testMode) return NULL;  /* do not open file in test mode */
 
     assert(dstFileName != NULL);
@@ -600,15 +602,16 @@ FIO_openDstFile(FIO_ctx_t* fCtx, FIO_prefs_t* const prefs,
         return NULL;
     }
 
+    isDstRegFile = UTIL_isRegularFile(dstFileName);  /* invoke once */
     if (prefs->sparseFileSupport == 1) {
-        if (!UTIL_isRegularFile(dstFileName)) {
+        if (!isDstRegFile) {
             prefs->sparseFileSupport = 0;
             DISPLAYLEVEL(4, "Sparse File Support is disabled when output is not a file \n");
         }
         prefs->sparseFileSupport = ZSTD_SPARSE_DEFAULT;
     }
 
-    if (UTIL_isRegularFile(dstFileName)) {
+    if (isDstRegFile) {
         /* Check if destination file already exists */
 #if !defined(_WIN32)
         /* this test does not work on Windows :