From: Uros Bizjak Date: Sat, 18 Jul 2015 11:36:32 +0000 (+0200) Subject: re PR target/66922 (wrong code for bit-field struct at -O1 and above on x86_64-linux... X-Git-Tag: releases/gcc-4.9.4~692 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1504c6a206b6f31174da607c047058965ef39a2e;p=thirdparty%2Fgcc.git re PR target/66922 (wrong code for bit-field struct at -O1 and above on x86_64-linux-gnu) PR target/66922 * config/i386/i386.c (ix86_expand_pinsr): Reject insertions to misaligned positions. testsuite/ChangeLog: PR target/66922 * gcc.target/i386/pr66922.c: New test. From-SVN: r225982 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e895ed07a851..cc3a787968ff 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-07-18 Uros Bizjak + + PR target/66922 + * config/i386/i386.c (ix86_expand_pinsr): Reject insertions + to misaligned positions. + 2015-07-17 Uros Bizjak PR target/66866 diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 7fc19e6b95d6..704e98639620 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -45381,6 +45381,10 @@ ix86_expand_pinsr (rtx *operands) return false; } + /* Reject insertions to misaligned positions. */ + if (pos & (size-1)) + return false; + rtx d = dst; if (GET_MODE (dst) != dstmode) d = gen_reg_rtx (dstmode); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 72bb72703bd9..3f601cbc81e0 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-07-18 Uros Bizjak + + PR target/66922 + * gcc.target/i386/pr66922.c: New test. + 2015-07-17 Uros Bizjak PR target/66866 diff --git a/gcc/testsuite/gcc.target/i386/pr66922.c b/gcc/testsuite/gcc.target/i386/pr66922.c new file mode 100644 index 000000000000..46274b22ce87 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr66922.c @@ -0,0 +1,23 @@ +/* { dg-do run } */ +/* { dg-options "-O1 -msse2" } */ +/* { dg-require-effective-target sse2 } */ + +#include "sse2-check.h" + +struct S +{ + int:31; + int:2; + int f0:16; + int f1; + int f2; +}; + +static void +sse2_test (void) +{ + struct S a = { 1, 0, 0 }; + + if (a.f0 != 1) + __builtin_abort(); +}