From: Luca Boccassi <bluca@debian.org>
Date: Fri, 6 Oct 2023 11:08:42 +0000 (+0100)
Subject: core: improve debug logs when failing to create symlinks in namespaces
X-Git-Tag: v255-rc1~304
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=15461b7f19272d39e59e4c6d87dfe9d48f4d1f99;p=thirdparty%2Fsystemd.git

core: improve debug logs when failing to create symlinks in namespaces

I am seeing some failures and I don't know what is failing and why even
with debug logs, so add more details
---

diff --git a/src/core/namespace.c b/src/core/namespace.c
index feedb283cdb..ffb1bb18874 100644
--- a/src/core/namespace.c
+++ b/src/core/namespace.c
@@ -1828,11 +1828,18 @@ static int create_symlinks_from_tuples(const char *root, char **strv_symlinks) {
 
                 r = mkdir_parents_label(dst_abs, 0755);
                 if (r < 0)
-                        return r;
+                        return log_debug_errno(
+                                        r,
+                                        "Failed to create parent directory for symlink '%s': %m",
+                                        dst_abs);
 
                 r = symlink_idempotent(src_abs, dst_abs, true);
                 if (r < 0)
-                        return r;
+                        return log_debug_errno(
+                                        r,
+                                        "Failed to create symlink from '%s' to '%s': %m",
+                                        src_abs,
+                                        dst_abs);
         }
 
         return 0;