From: Willy Tarreau <w@1wt.eu>
Date: Wed, 3 Apr 2024 09:30:07 +0000 (+0200)
Subject: BUG/MINOR: bwlim/config: fix missing '\n' after error messages
X-Git-Tag: v3.0-dev7~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=15522fc243a342f6f8d339f0940a571567bb19b8;p=thirdparty%2Fhaproxy.git

BUG/MINOR: bwlim/config: fix missing '\n' after error messages

Some bwlim error messages at parsing time were missing the trailing '\n'
in commit 2b6777021d ("MEDIUM: bwlim: Add support of bandwith limitation
at the stream level"). This commit can be backported wherever the commit
above is (likely as far as 2.7).
---

diff --git a/src/flt_bwlim.c b/src/flt_bwlim.c
index 66c2883df5..c5078c8419 100644
--- a/src/flt_bwlim.c
+++ b/src/flt_bwlim.c
@@ -219,26 +219,26 @@ static int bwlim_check(struct proxy *px, struct flt_conf *fconf)
 		target = px->table;
 
 	if (!target) {
-		ha_alert("Proxy %s : unable to find table '%s' referenced by bwlim filter '%s'",
+		ha_alert("Proxy %s : unable to find table '%s' referenced by bwlim filter '%s'\n",
 			 px->id, conf->table.n ? conf->table.n : px->id, conf->name);
 		return 1;
 	}
 
 	if ((conf->flags & BWLIM_FL_IN) && !target->data_ofs[STKTABLE_DT_BYTES_IN_RATE]) {
 		ha_alert("Proxy %s : stick-table '%s' uses a data type incompatible with bwlim filter '%s'."
-			 " It must be 'bytes_in_rate'",
+			 " It must be 'bytes_in_rate'\n",
 			 px->id, conf->table.n ? conf->table.n : px->id, conf->name);
 		return 1;
 	}
 	else if ((conf->flags & BWLIM_FL_OUT) && !target->data_ofs[STKTABLE_DT_BYTES_OUT_RATE]) {
 		ha_alert("Proxy %s : stick-table '%s' uses a data type incompatible with bwlim filter '%s'."
-			 " It must be 'bytes_out_rate'",
+			 " It must be 'bytes_out_rate'\n",
 			 px->id, conf->table.n ? conf->table.n : px->id, conf->name);
 		return 1;
 	}
 
 	if (!stktable_compatible_sample(conf->expr,  target->type)) {
-		ha_alert("Proxy %s : stick-table '%s' uses a key type incompatible with bwlim filter '%s'",
+		ha_alert("Proxy %s : stick-table '%s' uses a key type incompatible with bwlim filter '%s'\n",
 			 px->id, conf->table.n ? conf->table.n : px->id, conf->name);
 		return 1;
 	}