From: dmose%mozilla.org <>
Date: Fri, 28 Jul 2000 12:12:33 +0000 (+0000)
Subject: A menu was being created too early, before it is possible to avoid
X-Git-Tag: bugzilla-2.12~218
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1552368b2fd931bcc5d0e63a0e0b7c5f1cbd9632;p=thirdparty%2Fbugzilla.git

A menu was being created too early, before it is possible to avoid
creating the menu with an invalid default selection.  This was causing
bugzilla to (incorrectly) spew a database corruption error when
attempting to view a bug that had been resolved MOVED.  Why this
wasn't causing the same problem with DUPLICATE resolutions, I don't
know.  Moved the menu creation later in the code, so that it only
happens after it has been ensured that the default selection is not
going to be MOVED.
---

diff --git a/bug_form.pl b/bug_form.pl
index c41b51e6eb..3216ba42fd 100644
--- a/bug_form.pl
+++ b/bug_form.pl
@@ -140,8 +140,6 @@ GetVersionTable();
 # These should be read from the database ...
 #
 
-my $resolution_popup = make_options(\@::settable_resolution,
-				    $bug{'resolution'});
 my $platform_popup = make_options(\@::legal_platform, $bug{'rep_platform'});
 my $priority_popup = make_options(\@::legal_priority, $bug{'priority'});
 my $sev_popup = make_options(\@::legal_severity, $bug{'bug_severity'});
@@ -445,6 +443,8 @@ if ($canedit || $::userid == $assignedtoid ||
             print "<b>$bug{'resolution'}</b>)<br>\n";
             $knum++;
         }
+        my $resolution_popup = make_options(\@::settable_resolution,
+                                            $bug{'resolution'});
         print "<INPUT TYPE=radio NAME=knob VALUE=resolve>
         Resolve bug, changing <A HREF=\"bug_status.html\">resolution</A> to
         <SELECT NAME=resolution