From: lpsolit%gmail.com <>
Date: Wed, 10 Dec 2008 18:39:58 +0000 (+0000)
Subject: Bug 399076: Remove the 'commentonreassignbycomponent' parameter - Patch by FrédÃ... 
X-Git-Tag: bugzilla-3.3.1~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=15528ad8472cc0244cb2c7d9b6109c0b9d132f20;p=thirdparty%2Fbugzilla.git

Bug 399076: Remove the 'commentonreassignbycomponent' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index e9e73920a1..6399e34a43 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1752,11 +1752,6 @@ sub set_assigned_to {
 }
 sub reset_assigned_to {
     my $self = shift;
-    if (Bugzilla->params->{'commentonreassignbycomponent'} 
-        && !$self->{added_comments})
-    {
-        ThrowUserError('comment_required');
-    }
     my $comp = $self->component_obj;
     $self->set_assigned_to($comp->default_assignee);
 }
@@ -1997,11 +1992,6 @@ sub set_qa_contact {
 }
 sub reset_qa_contact {
     my $self = shift;
-    if (Bugzilla->params->{'commentonreassignbycomponent'}
-        && !$self->{added_comments})
-    {
-        ThrowUserError('comment_required');
-    }
     my $comp = $self->component_obj;
     $self->set_qa_contact($comp->default_qa_contact);
 }
diff --git a/Bugzilla/Config/BugChange.pm b/Bugzilla/Config/BugChange.pm
index 00a234a309..0e518b6899 100644
--- a/Bugzilla/Config/BugChange.pm
+++ b/Bugzilla/Config/BugChange.pm
@@ -86,12 +86,6 @@ sub get_param_list {
    default => 0
   },
 
-  {
-   name => 'commentonreassignbycomponent',
-   type => 'b',
-   default => 0
-  },
-
   {
    name => 'commentonduplicate',
    type => 'b',
diff --git a/template/en/default/admin/params/bugchange.html.tmpl b/template/en/default/admin/params/bugchange.html.tmpl
index b00fea05e1..9f456ee6f5 100644
--- a/template/en/default/admin/params/bugchange.html.tmpl
+++ b/template/en/default/admin/params/bugchange.html.tmpl
@@ -43,9 +43,6 @@
   commentonchange_resolution => "If this option is on, the user needs to enter a short " _
                                 "comment if the resolution of the $terms.bug changes.",
 
-  commentonreassignbycomponent => "If this option is on, the user needs to enter a short comment if " _
-                                  "the $terms.bug is reassigned by component.",
-
   commentonduplicate => "If this option is on, the user needs to enter a short comment " _
                         "if the $terms.bug is marked as duplicate.",