From: Mark Michelson <mmichelson@digium.com>
Date: Mon, 29 Jun 2015 17:45:02 +0000 (-0500)
Subject: res_sorcery_realtime: Fix leak of sorcery object type.
X-Git-Tag: 13.5.0-rc1~66^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=156395e743189649280066c1497292bb97ed022d;p=thirdparty%2Fasterisk.git

res_sorcery_realtime: Fix leak of sorcery object type.

This prevents a leak of a sorcery object type when realtime sorcery
objects are retrieved by fields or when multiple objects are retrieved.

The extent of this leak is that sorcery object types would be leaked.
These are allocated whenever an object type is registered with sorcery,
meaning that on module shutdown, these objects would be leaked. This
could be problematic if many reloads were performed, but it is not as
severe as if every sorcery object retrieved from realtime were being
leaked.

ASTERISK-25165 #close
Reported by Corey Farrell

Change-Id: I625c3b50eee4576670b7eeb013c81ad043b4b4f8
---

diff --git a/res/res_sorcery_realtime.c b/res/res_sorcery_realtime.c
index fcdc2a9717..fc22170a57 100644
--- a/res/res_sorcery_realtime.c
+++ b/res/res_sorcery_realtime.c
@@ -142,6 +142,8 @@ static struct ast_variable *sorcery_realtime_filter_objectset(struct ast_variabl
 		}
 	}
 
+	ao2_ref(object_type, -1);
+
 	return objectset;
 }