From: Victor Julien <vjulien@oisf.net>
Date: Tue, 26 Apr 2022 18:12:20 +0000 (+0200)
Subject: classification: remove useless clear
X-Git-Tag: suricata-5.0.10~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1591427770a94a0385df21cb06e4ed6620e06e34;p=thirdparty%2Fsuricata.git

classification: remove useless clear

cppcheck:

src/util-classification-config.c:189:9: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
        fd = NULL;
        ^

Bug: #5291.
(cherry picked from commit 9c672a805fe1fe78591ec0f06da56e23c99d0751)
---

diff --git a/src/util-classification-config.c b/src/util-classification-config.c
index c71ede6cc3..900f75fe11 100644
--- a/src/util-classification-config.c
+++ b/src/util-classification-config.c
@@ -187,7 +187,6 @@ static void SCClassConfDeInitLocalResources(DetectEngineCtx *de_ctx, FILE *fd)
 {
     if (fd != NULL) {
         fclose(fd);
-        fd = NULL;
     }
 }