From: Jouni Malinen <jouni@qca.qualcomm.com>
Date: Mon, 28 Dec 2015 16:12:03 +0000 (+0200)
Subject: Remove unnecessary cleanup assignment in SHA1Final()
X-Git-Tag: hostap_2_6~1083
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=15a68138c1da0ec509d09bbd143c17abc720b29a;p=thirdparty%2Fhostap.git

Remove unnecessary cleanup assignment in SHA1Final()

This makes some static analyzers complain about stored value never being
read. While it is good to clear some other temporary variables, this
local variable i has no security private information (it has a fixed
value of 20 here) and trying to clear it to 0 does not add any value.
Remove that part of the "wipe variables" to avoid one useless static
analyzer complaint.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
---

diff --git a/src/crypto/sha1-internal.c b/src/crypto/sha1-internal.c
index f6658e6ee..ffcba66af 100644
--- a/src/crypto/sha1-internal.c
+++ b/src/crypto/sha1-internal.c
@@ -297,7 +297,6 @@ void SHA1Final(unsigned char digest[20], SHA1_CTX* context)
 			 255);
 	}
 	/* Wipe variables */
-	i = 0;
 	os_memset(context->buffer, 0, 64);
 	os_memset(context->state, 0, 20);
 	os_memset(context->count, 0, 8);