From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 8 Jan 2020 08:18:30 +0000 (+0100)
Subject: virchrdev: Don't leak mutex if virChrdevAlloc() fails
X-Git-Tag: v6.1.0-rc1~510
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=15b821122e6c13b796415c06ecf41be167bc519c;p=thirdparty%2Flibvirt.git

virchrdev: Don't leak mutex if virChrdevAlloc() fails

This is only a theoretical leak, but in virChrdevAlloc() we
initialize a mutex and if creating a hash table fails,
then virChrdevFree() is called which because of incorrect check
doesn't deinit the mutex.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index 7657c41ece..6e659a3783 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -311,7 +311,7 @@ static int virChrdevFreeClearCallbacks(void *payload,
  */
 void virChrdevFree(virChrdevsPtr devs)
 {
-    if (!devs || !devs->hash)
+    if (!devs)
         return;
 
     virMutexLock(&devs->lock);