From: Jeremy Allison <jra@samba.org>
Date: Fri, 10 Jan 2020 23:55:29 +0000 (-0800)
Subject: s3: lib: dbwrap. Cleanup. Add a couple of missing 'return NULL' statements on talloc... 
X-Git-Tag: ldb-2.1.0~48
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=15ee379ef11d86670aeea7fa4b8bf740dd259593;p=thirdparty%2Fsamba.git

s3: lib: dbwrap. Cleanup. Add a couple of missing 'return NULL' statements on talloc fail.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/source3/lib/dbwrap/dbwrap_ctdb.c b/source3/lib/dbwrap/dbwrap_ctdb.c
index 11710603a5e..3cbed6322b3 100644
--- a/source3/lib/dbwrap/dbwrap_ctdb.c
+++ b/source3/lib/dbwrap/dbwrap_ctdb.c
@@ -554,6 +554,7 @@ static struct db_record *db_ctdb_fetch_locked_transaction(struct db_ctdb_ctx *ct
 			 result->value.dsize))) {
 		DEBUG(0, ("talloc failed\n"));
 		TALLOC_FREE(result);
+		return NULL;
 	}
 	result->value_valid = true;
 
@@ -1246,6 +1247,7 @@ again:
 		if (result->value.dptr == NULL) {
 			DBG_ERR("talloc failed\n");
 			TALLOC_FREE(result);
+			return NULL;
 		}
 	}
 	result->value_valid = true;