From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 16 Apr 2010 21:03:55 +0000 (+0200)
Subject: SOCKS4: Value stored to 'rc' is never read
X-Git-Tag: curl-7_21_0~144^2~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=15fa5dcfe6ad34f8f9d360163c44caf05c771210;p=thirdparty%2Fcurl.git

SOCKS4: Value stored to 'rc' is never read
---

diff --git a/lib/socks.c b/lib/socks.c
index 0b051545c4..df301ecec8 100644
--- a/lib/socks.c
+++ b/lib/socks.c
@@ -172,8 +172,8 @@ CURLcode Curl_SOCKS4(const char *proxy_name,
       return CURLE_COULDNT_RESOLVE_PROXY;
 
     if(rc == CURLRESOLV_PENDING)
-      /* this requires that we're in "wait for resolve" state */
-      rc = Curl_wait_for_resolv(conn, &dns);
+      /* ignores the return code, but 'dns' remains NULL on failure */
+      (void)Curl_wait_for_resolv(conn, &dns);
 
     /*
      * We cannot use 'hostent' as a struct that Curl_resolv() returns.  It