From: Ján Tomko <jtomko@redhat.com>
Date: Sat, 18 Mar 2023 11:34:47 +0000 (+0100)
Subject: vbox: remove unreachable error in virVBoxSnapshotConfSaveVboxFile
X-Git-Tag: v9.2.0-rc1~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=161e21018a178c3ba05d82e30b36a258f5a61fc8;p=thirdparty%2Flibvirt.git

vbox: remove unreachable error in virVBoxSnapshotConfSaveVboxFile

Both callers in the VirtualBox driver handle the error and only
call this function with a non-NULL argument.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
---

diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c
index a6e5fad4d2..78fb360e1e 100644
--- a/src/vbox/vbox_snapshot_conf.c
+++ b/src/vbox/vbox_snapshot_conf.c
@@ -952,11 +952,6 @@ virVBoxSnapshotConfSaveVboxFile(virVBoxSnapshotConfMachine *machine,
                        _("Machine is null"));
         goto cleanup;
     }
-    if (filePath == NULL) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("Filepath is null"));
-        goto cleanup;
-    }
     xml = xmlNewDoc(BAD_CAST "1.0");
     if (!xml)
         abort();