From: Andrew Pinski <quic_apinski@quicinc.com>
Date: Wed, 2 Oct 2024 21:21:24 +0000 (-0700)
Subject: aarch64: Fix early ra for -fno-delete-dead-exceptions [PR116927]
X-Git-Tag: releases/gcc-14.3.0~193
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=16446f19f1313c57a312857026b6982aaa7241c7;p=thirdparty%2Fgcc.git

aarch64: Fix early ra for -fno-delete-dead-exceptions [PR116927]

Early-RA was considering throwing instructions as being dead and removing
them even if -fno-delete-dead-exceptions was in use. This fixes that oversight.

Built and tested for aarch64-linux-gnu.

	PR target/116927

gcc/ChangeLog:

	* config/aarch64/aarch64-early-ra.cc (early_ra::is_dead_insn): Insns
	that throw are not dead with -fno-delete-dead-exceptions.

gcc/testsuite/ChangeLog:

	* g++.dg/torture/pr116927-1.C: New test.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
(cherry picked from commit edec4bfc99744b48da3ffde1e4f39c9aceecfd42)
---

diff --git a/gcc/config/aarch64/aarch64-early-ra.cc b/gcc/config/aarch64/aarch64-early-ra.cc
index dd2ed762f8a..427b6a13aec 100644
--- a/gcc/config/aarch64/aarch64-early-ra.cc
+++ b/gcc/config/aarch64/aarch64-early-ra.cc
@@ -3437,6 +3437,12 @@ early_ra::is_dead_insn (rtx_insn *insn)
   if (side_effects_p (set))
     return false;
 
+  /* If we can't delete dead exceptions and the insn throws,
+     then the instruction is not dead.  */
+  if (!cfun->can_delete_dead_exceptions
+      && !insn_nothrow_p (insn))
+    return false;
+
   return true;
 }
 
diff --git a/gcc/testsuite/g++.dg/torture/pr116927-1.C b/gcc/testsuite/g++.dg/torture/pr116927-1.C
new file mode 100644
index 00000000000..22fa1dbd7e1
--- /dev/null
+++ b/gcc/testsuite/g++.dg/torture/pr116927-1.C
@@ -0,0 +1,15 @@
+// { dg-do compile }
+// { dg-additional-options "-fnon-call-exceptions -fno-delete-dead-exceptions" }
+
+// PR target/116927
+// aarch64's Early ra was removing possiblely trapping
+// floating point insn
+
+void
+foo (float f)
+{
+  try {
+    f ++;
+  }catch(...)
+  {}
+}