From: Howard Chu <hyc@openldap.org>
Date: Sun, 1 Apr 2007 11:53:06 +0000 (+0000)
Subject: ITS#4899 fix from HEAD
X-Git-Tag: OPENLDAP_REL_ENG_2_3_35~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1656b527a4ebae18827b1e4c82ec99c488cf2e42;p=thirdparty%2Fopenldap.git

ITS#4899 fix from HEAD
---

diff --git a/libraries/libldap_r/tpool.c b/libraries/libldap_r/tpool.c
index d710acbcff..e862da6c22 100644
--- a/libraries/libldap_r/tpool.c
+++ b/libraries/libldap_r/tpool.c
@@ -596,13 +596,25 @@ int ldap_pvt_thread_pool_setkey(
 	if ( !ctx || !key ) return EINVAL;
 
 	for ( i=0; i<MAXKEYS; i++ ) {
-		if ( !ctx[i].ltk_key || ctx[i].ltk_key == key ) {
-			if ( data || kfree )
+		if (( data && !ctx[i].ltk_key ) || ctx[i].ltk_key == key ) {
+			if ( data || kfree ) {
 				ctx[i].ltk_key = key;
-			else
-				ctx[i].ltk_key = NULL;
-			ctx[i].ltk_data = data;
-			ctx[i].ltk_free = kfree;
+				ctx[i].ltk_data = data;
+				ctx[i].ltk_free = kfree;
+			} else {
+				int j;
+				for ( j=i+1; j<MAXKEYS; j++ )
+					if ( !ctx[j].ltk_key ) break;
+				j--;
+				if ( j != i ) {
+					ctx[i].ltk_key = ctx[j].ltk_key;
+					ctx[i].ltk_data = ctx[j].ltk_data;
+					ctx[i].ltk_free = ctx[j].ltk_free;
+				}
+				ctx[j].ltk_key = NULL;
+				ctx[j].ltk_data = NULL;
+				ctx[j].ltk_free = NULL;
+			}
 			return 0;
 		}
 	}