From: Philippe Antoine <contact@catenacyber.fr>
Date: Thu, 27 Aug 2020 15:11:10 +0000 (+0200)
Subject: detect: checks for overflow when comparing signatures priorities
X-Git-Tag: suricata-6.0.0-rc1~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=16742394424e8c9654708fbc93b990b9ddc70dff;p=thirdparty%2Fsuricata.git

detect: checks for overflow when comparing signatures priorities
---

diff --git a/src/detect-engine-sigorder.c b/src/detect-engine-sigorder.c
index 6cfa2d9e8a..469af1f60b 100644
--- a/src/detect-engine-sigorder.c
+++ b/src/detect-engine-sigorder.c
@@ -682,7 +682,12 @@ static int SCSigOrderByIPPairbitsCompare(SCSigSignatureWrapper *sw1,
 static int SCSigOrderByPriorityCompare(SCSigSignatureWrapper *sw1,
                                        SCSigSignatureWrapper *sw2)
 {
-    return sw2->sig->prio - sw1->sig->prio;
+    if (sw1->sig->prio > sw2->sig->prio) {
+        return -1;
+    } else if (sw1->sig->prio < sw2->sig->prio) {
+        return 1;
+    }
+    return 0;
 }
 
 /**